Required check on swipe vs. save

Hello all.

At The Carter Center we maintain a separate build of ODK, mostly due to
ODK's stock behaviour of validating required questions on swipe, rather
than on save. Observers often want to fill out questions in non-sequential
order, and so they get annoyed when they are blocked from proceeding due to
a required check. So I wrote a patch that moves the required check to the
save action.

Most of the other reasons that we maintain a separate build have gone away
as patches we have submitted have been accepted and as other nice features
have been added. So this is basically the only one keeping us from using
the mainline, which would be nice for a bunch of reasons.

I understand that some users probably like the required check the way it
is, so I'm proposing to write a patch that would add a new Preference under
User Interface called "Required question check" and would have two options:
"When question changed" (default) and "When form saved". If the Admin
Settings are not auto populated from the Preferences (I haven't checked),
then I would also add a corresponding option there.

What are people's feelings on this? Could I count on the patch being
accepted into the mainline in fairly short order, assuming it doesn't suck?

Thanks for considering,

Tom

Can you give us a patch?

In the patch, this should appear under the Admin Settings menu as a new
PreferenceCategory "Form Processing Behavior", probably as the first
category, since it is so important.
The checkbox preference under this would be "Defer Validation until
Finalized"

If you provide the patch, we can apply it to the codebase.

ยทยทยท On Wed, Jul 10, 2013 at 6:38 AM, Thomas Smyth wrote:

Hello all.

At The Carter Center we maintain a separate build of ODK, mostly due to
ODK's stock behaviour of validating required questions on swipe, rather
than on save. Observers often want to fill out questions in non-sequential
order, and so they get annoyed when they are blocked from proceeding due to
a required check. So I wrote a patch that moves the required check to the
save action.

Most of the other reasons that we maintain a separate build have gone away
as patches we have submitted have been accepted and as other nice features
have been added. So this is basically the only one keeping us from using
the mainline, which would be nice for a bunch of reasons.

I understand that some users probably like the required check the way it
is, so I'm proposing to write a patch that would add a new Preference under
User Interface called "Required question check" and would have two options:
"When question changed" (default) and "When form saved". If the Admin
Settings are not auto populated from the Preferences (I haven't checked),
then I would also add a corresponding option there.

What are people's feelings on this? Could I count on the patch being
accepted into the mainline in fairly short order, assuming it doesn't suck?

Thanks for considering,

Tom

--
You received this message because you are subscribed to the Google Groups
"ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Mitch Sundt
Software Engineer
University of Washington
mitchellsundt@gmail.com

Patch is attached. I tested it on my phone and it works fine. Let me know
if you have any issues. Also please let me know when this has been merged
into the default branch.

When (ballpark) should we expect the next release of ODK containing this
and the gzip patch?

Thanks so much!

constraint-behavior-patch.diff (9.56 KB)

ยทยทยท On 10 July 2013 16:37, Mitch Sundt wrote:

Can you give us a patch?

In the patch, this should appear under the Admin Settings menu as a new
PreferenceCategory "Form Processing Behavior", probably as the first
category, since it is so important.
The checkbox preference under this would be "Defer Validation until
Finalized"

If you provide the patch, we can apply it to the codebase.

On Wed, Jul 10, 2013 at 6:38 AM, Thomas Smyth tom@sassafrastech.comwrote:

Hello all.

At The Carter Center we maintain a separate build of ODK, mostly due to
ODK's stock behaviour of validating required questions on swipe, rather
than on save. Observers often want to fill out questions in non-sequential
order, and so they get annoyed when they are blocked from proceeding due to
a required check. So I wrote a patch that moves the required check to the
save action.

Most of the other reasons that we maintain a separate build have gone
away as patches we have submitted have been accepted and as other nice
features have been added. So this is basically the only one keeping us from
using the mainline, which would be nice for a bunch of reasons.

I understand that some users probably like the required check the way it
is, so I'm proposing to write a patch that would add a new Preference under
User Interface called "Required question check" and would have two options:
"When question changed" (default) and "When form saved". If the Admin
Settings are not auto populated from the Preferences (I haven't checked),
then I would also add a corresponding option there.

What are people's feelings on this? Could I count on the patch being
accepted into the mainline in fairly short order, assuming it doesn't suck?

Thanks for considering,

Tom

--
You received this message because you are subscribed to the Google Groups
"ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Mitch Sundt
Software Engineer
University of Washington
mitchellsundt@gmail.com

--
You received this message because you are subscribed to the Google Groups
"ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

1 Like