Hi ODK Dev,
I just submitted a pull request for the collect GitHub project (collect#19), and after seeing how issues are being managed. I realized that may not be how you would like things to be submitted. I searched for docs and/or discussion on the subject and couldn't find anything pertinent so I figured I would ask here.
What is the normal/preferred way to contribute fixes like this?
Thanks,
Brent
Hi Brent,
Long time no talk!
I don't think any of that is documented, so it's best to assume it's
adhoc at best. Is there a popular process that you like? If so, I'm
sure the core team would appreciate it if you took the lead on
proposing and helping to implement such a protocol.
Thanks,
Yaw
Hi Yaw,
It has been a long time indeed! It is good to hear from you and I hope you
are well.
Thank you for the information. It is good to know I didn't just botch the
search. I am not sure I can suggest a better process, but I wanted to ask
because I was not sure the PRs submitted to the project repos such as
https://github.com/opendatakit/collect/pulls are manageable as others in
the main issue tracker https://github.com/opendatakit/opendatakit/issues.
I have not run a split like this in GitHub before, but my hunch was that
the pull requests aren't automatically visible in the tracker. If it is
better that I create an issue and reference the pull request so it can be
scheduled like others in https://github.com/opendatakit/opendatakit/issues,
I am happy to do so.
Thanks again,
Brent
Hi Brent,
Long time no talk!
I don't think any of that is documented, so it's best to assume it's
adhoc at best. Is there a popular process that you like? If so, I'm
sure the core team would appreciate it if you took the lead on
proposing and helping to implement such a protocol.Thanks,
Yaw
On Fri, Jun 17, 2016 at 8:56 PM, brent.atkinson@gmail.com wrote:
Hi ODK Dev,
I just submitted a pull request for the collect GitHub project
(collect#19), and after seeing how issues are being managed. I realized
that may not be how you would like things to be submitted. I searched for
docs and/or discussion on the subject and couldn't find anything pertinent
so I figured I would ask here.What is the normal/preferred way to contribute fixes like this?
Thanks,
Brent
--
You received this message because you are subscribed to the Google
Groups "ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to a topic in the
Google Groups "ODK Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/opendatakit-developers/6i6i1PShYJs/unsubscribe
.
To unsubscribe from this group and all its topics, send an email to
opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Whatever you did works. I see the PR.
We are slammed on 2.0 work, so this won't get reviewed for a while.
Hi Yaw,
It has been a long time indeed! It is good to hear from you and I hope you
are well.Thank you for the information. It is good to know I didn't just botch the
search. I am not sure I can suggest a better process, but I wanted to ask
because I was not sure the PRs submitted to the project repos such as
https://github.com/opendatakit/collect/pulls are manageable as others in
the main issue tracker https://github.com/opendatakit/opendatakit/issues.I have not run a split like this in GitHub before, but my hunch was that
the pull requests aren't automatically visible in the tracker. If it is
better that I create an issue and reference the pull request so it can be
scheduled like others in https://github.com/opendatakit/opendatakit/issues,
I am happy to do so.Thanks again,
Brent
On Thu, Jun 23, 2016 at 8:08 AM, Yaw Anokwa yanokwa@nafundi.com wrote:
Hi Brent,
Long time no talk!
I don't think any of that is documented, so it's best to assume it's
adhoc at best. Is there a popular process that you like? If so, I'm
sure the core team would appreciate it if you took the lead on
proposing and helping to implement such a protocol.Thanks,
Yaw
On Fri, Jun 17, 2016 at 8:56 PM, brent.atkinson@gmail.com wrote:
Hi ODK Dev,
I just submitted a pull request for the collect GitHub project
(collect#19), and after seeing how issues are being managed. I realized
that may not be how you would like things to be submitted. I searched for
docs and/or discussion on the subject and couldn't find anything pertinent
so I figured I would ask here.What is the normal/preferred way to contribute fixes like this?
Thanks,
Brent
--
You received this message because you are subscribed to the Google
Groups "ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to a topic in the
Google Groups "ODK Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/opendatakit-developers/6i6i1PShYJs/unsubscribe
.
To unsubscribe from this group and all its topics, send an email to
opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups
"ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Mitch Sundt
Software Engineer
University of Washington
mitchellsundt@gmail.com
Hi Mitch,
Thanks for the feedback. The changes are fairly minimal, but if there's
anything I can do to make things easier just let me know.
Brent
Whatever you did works. I see the PR.
We are slammed on 2.0 work, so this won't get reviewed for a while.
On Thu, Jun 23, 2016 at 11:22 AM, Brent Atkinson <brent.atkinson@gmail.com wrote:
Hi Yaw,
It has been a long time indeed! It is good to hear from you and I hope
you are well.Thank you for the information. It is good to know I didn't just botch the
search. I am not sure I can suggest a better process, but I wanted to ask
because I was not sure the PRs submitted to the project repos such as
https://github.com/opendatakit/collect/pulls are manageable as others in
the main issue tracker https://github.com/opendatakit/opendatakit/issues.I have not run a split like this in GitHub before, but my hunch was that
the pull requests aren't automatically visible in the tracker. If it is
better that I create an issue and reference the pull request so it can be
scheduled like others in
https://github.com/opendatakit/opendatakit/issues, I am happy to do so.Thanks again,
Brent
On Thu, Jun 23, 2016 at 8:08 AM, Yaw Anokwa yanokwa@nafundi.com wrote:
Hi Brent,
Long time no talk!
I don't think any of that is documented, so it's best to assume it's
adhoc at best. Is there a popular process that you like? If so, I'm
sure the core team would appreciate it if you took the lead on
proposing and helping to implement such a protocol.Thanks,
Yaw
On Fri, Jun 17, 2016 at 8:56 PM, brent.atkinson@gmail.com wrote:
Hi ODK Dev,
I just submitted a pull request for the collect GitHub project
(collect#19), and after seeing how issues are being managed. I realized
that may not be how you would like things to be submitted. I searched for
docs and/or discussion on the subject and couldn't find anything pertinent
so I figured I would ask here.What is the normal/preferred way to contribute fixes like this?
Thanks,
Brent
--
You received this message because you are subscribed to the Google
Groups "ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to a topic in the
Google Groups "ODK Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/opendatakit-developers/6i6i1PShYJs/unsubscribe
.
To unsubscribe from this group and all its topics, send an email to
opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups
"ODK Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.--
Mitch Sundt
Software Engineer
University of Washington
mitchellsundt@gmail.com--
You received this message because you are subscribed to a topic in the
Google Groups "ODK Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/opendatakit-developers/6i6i1PShYJs/unsubscribe
.
To unsubscribe from this group and all its topics, send an email to
opendatakit-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.