Collect: Project settings - Allow complex emojis in icon

qlands · July 29, 2021, 7:57pm

The multiple project feature is brilliant. Currently, the Icon can handle one character which is great for emojis. But it would be good to support complex emojis like the Argentina Flag () which combines 2 unicode characters.

I have the source code of Collect. I could make the modifications myself if someone points me to the class file

Thanks.

LN · July 29, 2021, 9:43pm

Glad to hear you're enjoying multiple projects!

Thanks for bringing up the issue with complex emojis. We spotted it but forgot to file an issue and haven't had time to address it. A contribution would be welcome and if you get it in by next week it can likely go in a point release. OneSignTextWatcher performs the truncation as the project icon is manually set. Then ProjectDetailsCreator.createProjectFromDetails ensures that what is saved is truncated no matter how the icon was set.

Please start by filing an issue with a proposed approach -- I don't think this is quite obvious.

qlands · August 14, 2021, 6:21pm

OK. I'm on it.

Cheers

qlands · August 15, 2021, 1:32pm

OK. Done and tested.

github.com/getodk/collect

Allow complex emojis in icon

getodk:v2021.2.x ← qlands:fix-icon-size

opened 03:04AM - 15 Aug 21 UTC

qlands

+35 -11

Closes #4790 #### What has been done to verify that this works as intended? …I build the APK locally using Android Studio Bumblebee | 2021.1.1 Canary 8 and I test it on an Android Pixel 4a. Updated tests and ran ./gradlew testDebug #### Why is this the best possible solution? Were any other approaches considered? Working with Emojis is complicated. There are combinations of Emojis to create one. Using length() is not an approach. And instead of writing custom complex code to control Emojis it is better to use a Emoji-Java (https://github.com/vdurmont/emoji-java) #### How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks? Users will be able to use complex Emojis. For example (family: man, woman, girl, boy) (1F468 200D 1F469 200D 1F467 200D 1F466) 👨‍👩‍👧‍👦 . No regression risks because we only allowing 1 character or 1 complex emoji #### Do we need any specific form for testing your changes? If so, please attach one. No. This change applies to the interface. I tested with different cases: For changing the icon in Collect - If the text input contains only text then limit the number of characters to 1 - If the text input contains only emojis hen limit the number of emojis to 1 using emoji-java - If the text input contains a character and the user selects an emoji then replace the character with the emoji. When reading a QR code with an icon: - If the icon contains only text then use the first character uppercased - If the icon contains only emojis then use the first emoji using emoji-java - If the icon contains text and emojis then use the first emoji using emoji-java #### Does this change require updates to documentation? If so, please file an issue [here]( https://github.com/getodk/docs/issues/new) and include the link below. I don't think so because icon is not currently documented in https://docs.getodk.org/ #### Before submitting this PR, please make sure you have: - [x] run `./gradlew checkAll` and confirmed all checks still pass OR confirm CircleCI build passes and run `./gradlew connectedDebugAndroidTest` locally. - [x] verified that any code or assets from external sources are properly credited in comments and/or in the [about file](https://github.com/getodk/collect/blob/master/collect_app/src/main/assets/open_source_licenses.html). - [x] verified that any new UI elements use theme colors. [UI Components Style guidelines](https://github.com/getodk/collect/blob/master/CONTRIBUTING.md#ui-components-style-guidelines)

yanokwa · August 19, 2021, 11:02pm

Complex emoji support is now in ODK Collect v2021.2. Thanks for the PR, @qlands!