ODK Collect Authentication modification

ODK Collect developers,

I'm working on a project that required doing authentication a bit
differently than the way that Aggregate does (specifically, using
the built-in Android authentication to Google's servers).

I would be very interested in getting this patch put into the mainline.
(The code is not yet completely final, as it currently only gets
authorization to access contact information, where it will need a larger set
of permissions upon final release.)

I had to make some guesses as to the best way to integrate this
authentication method as unobtrusively as possible -- I added a "Google"
entry under the Server -> Authentication, which activates a button on the
main menu to select which account to use.

Patch is attached. Comments and critiques are welcome.

--Christopher

odk-collect-patch.txt (19 KB)

··· -- Christopher Swenson cswenson@google.com

hey christoper,

thanks for the submission! i've filed the patch at
http://code.google.com/p/opendatakit/issues/detail?id=312. i think
we'll be able to sneak it into the 1.1.7 release.

i just took a quick look, and i'm not excited about pushing the
account selection to the main menu. is there a reason why the
selection of the account can't be done in the preference activity? so
you select the account, it launches the account selector, and when it
returns, that choice is stored in the preferences...

yaw

··· On Tue, Aug 30, 2011 at 19:05, Christopher Swenson wrote: > ODK Collect developers, > I'm working on a project that required doing authentication a bit > differently than the way that Aggregate does (specifically, using > the built-in Android authentication to Google's servers). > I would be very interested in getting this patch put into the mainline. > (The code is not yet completely final, as it currently only gets > authorization to access contact information, where it will need a larger set > of permissions upon final release.) > I had to make some guesses as to the best way to integrate this > authentication method as unobtrusively as possible -- I added a "Google" > entry under the Server -> Authentication, which activates a button on the > main menu to select which account to use. > Patch is attached. Comments and critiques are welcome. > --Christopher > -- > Christopher Swenson > cswenson@google.com > >

That should be fine.

I realized another implication -- the AccountManager only became available
in Android 2.1 or so. :confused: (Though I noticed that several of the UI changes
seemed to require a higher version, as I couldn't get the project to compile
without targeting a later version.)

--Christopher

··· On Wed, Aug 31, 2011 at 12:05 AM, Yaw Anokwa wrote:

hey christoper,

thanks for the submission! i've filed the patch at
http://code.google.com/p/opendatakit/issues/detail?id=312. i think
we'll be able to sneak it into the 1.1.7 release.

i just took a quick look, and i'm not excited about pushing the
account selection to the main menu. is there a reason why the
selection of the account can't be done in the preference activity? so
you select the account, it launches the account selector, and when it
returns, that choice is stored in the preferences...

yaw

On Tue, Aug 30, 2011 at 19:05, Christopher Swenson cswenson@google.com wrote:

ODK Collect developers,
I'm working on a project that required doing authentication a bit
differently than the way that Aggregate does (specifically, using
the built-in Android authentication to Google's servers).
I would be very interested in getting this patch put into the mainline.
(The code is not yet completely final, as it currently only gets
authorization to access contact information, where it will need a larger
set
of permissions upon final release.)
I had to make some guesses as to the best way to integrate this
authentication method as unobtrusively as possible -- I added a "Google"
entry under the Server -> Authentication, which activates a button on the
main menu to select which account to use.
Patch is attached. Comments and critiques are welcome.
--Christopher

Christopher Swenson
cswenson@google.com

--
Christopher Swenson
cswenson@google.com

Please don't forget about my authentication patches! It would be nice
to have them in 1.1.7 as well...

··· On 31 August 2011 01:05, Yaw Anokwa wrote: > hey christoper, > > thanks for the submission! i've filed the patch at > http://code.google.com/p/opendatakit/issues/detail?id=312. i think > we'll be able to sneak it into the 1.1.7 release. > > i just took a quick look, and i'm not excited about pushing the > account selection to the main menu. is there a reason why the > selection of the account can't be done in the preference activity? so > you select the account, it launches the account selector, and when it > returns, that choice is stored in the preferences... > > yaw > > On Tue, Aug 30, 2011 at 19:05, Christopher Swenson wrote: >> ODK Collect developers, >> I'm working on a project that required doing authentication a bit >> differently than the way that Aggregate does (specifically, using >> the built-in Android authentication to Google's servers). >> I would be very interested in getting this patch put into the mainline. >> (The code is not yet completely final, as it currently only gets >> authorization to access contact information, where it will need a larger set >> of permissions upon final release.) >> I had to make some guesses as to the best way to integrate this >> authentication method as unobtrusively as possible -- I added a "Google" >> entry under the Server -> Authentication, which activates a button on the >> main menu to select which account to use. >> Patch is attached. Comments and critiques are welcome. >> --Christopher >> -- >> Christopher Swenson >> cswenson@google.com >> >> >

I forgot to include a few files in the last patch.

Attached is an updated patch.

--Christopher

odk-collect-patch.txt (26.7 KB)

··· On Wed, Aug 31, 2011 at 2:56 PM, Thomas Smyth wrote:

Please don't forget about my authentication patches! It would be nice
to have them in 1.1.7 as well...

On 31 August 2011 01:05, Yaw Anokwa yanokwa@gmail.com wrote:

hey christoper,

thanks for the submission! i've filed the patch at
http://code.google.com/p/opendatakit/issues/detail?id=312. i think
we'll be able to sneak it into the 1.1.7 release.

i just took a quick look, and i'm not excited about pushing the
account selection to the main menu. is there a reason why the
selection of the account can't be done in the preference activity? so
you select the account, it launches the account selector, and when it
returns, that choice is stored in the preferences...

yaw

On Tue, Aug 30, 2011 at 19:05, Christopher Swenson cswenson@google.com wrote:

ODK Collect developers,
I'm working on a project that required doing authentication a bit
differently than the way that Aggregate does (specifically, using
the built-in Android authentication to Google's servers).
I would be very interested in getting this patch put into the mainline.
(The code is not yet completely final, as it currently only gets
authorization to access contact information, where it will need a larger
set

of permissions upon final release.)
I had to make some guesses as to the best way to integrate this
authentication method as unobtrusively as possible -- I added a "Google"
entry under the Server -> Authentication, which activates a button on
the

main menu to select which account to use.
Patch is attached. Comments and critiques are welcome.
--Christopher

Christopher Swenson
cswenson@google.com

--
Christopher Swenson
cswenson@google.com

Just thought I would ping people on this -- I would be happy to work with
you on modifying this to meet your UI suggestions and to get this rolled
into the next version.

--Christopher

··· On Thu, Sep 8, 2011 at 12:22 PM, Christopher Swenson wrote:

I forgot to include a few files in the last patch.

Attached is an updated patch.

--Christopher

On Wed, Aug 31, 2011 at 2:56 PM, Thomas Smyth thomas.smyth@gatech.eduwrote:

Please don't forget about my authentication patches! It would be nice
to have them in 1.1.7 as well...

On 31 August 2011 01:05, Yaw Anokwa yanokwa@gmail.com wrote:

hey christoper,

thanks for the submission! i've filed the patch at
http://code.google.com/p/opendatakit/issues/detail?id=312. i think
we'll be able to sneak it into the 1.1.7 release.

i just took a quick look, and i'm not excited about pushing the
account selection to the main menu. is there a reason why the
selection of the account can't be done in the preference activity? so
you select the account, it launches the account selector, and when it
returns, that choice is stored in the preferences...

yaw

On Tue, Aug 30, 2011 at 19:05, Christopher Swenson cswenson@google.com wrote:

ODK Collect developers,
I'm working on a project that required doing authentication a bit
differently than the way that Aggregate does (specifically, using
the built-in Android authentication to Google's servers).
I would be very interested in getting this patch put into the mainline.
(The code is not yet completely final, as it currently only gets
authorization to access contact information, where it will need a
larger set

of permissions upon final release.)
I had to make some guesses as to the best way to integrate this
authentication method as unobtrusively as possible -- I added a
"Google"

entry under the Server -> Authentication, which activates a button on
the

main menu to select which account to use.
Patch is attached. Comments and critiques are welcome.
--Christopher

Christopher Swenson
cswenson@google.com

--
Christopher Swenson
cswenson@google.com

--
Christopher Swenson
cswenson@google.com